Skip to content

credential.c: fix credential reading for DOS systems #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

credential.c: fix credential reading for DOS systems #2516

merged 1 commit into from
Feb 13, 2020

Conversation

nyckyta
Copy link

@nyckyta nyckyta commented Feb 13, 2020 •
edited
Loading

This fix makes using git credentials more friendly to Windows users. In previous version it was unable to finish input correctly without configuration changes (was tested in powershell, cmd, cygwin).
As we know credential filling should be finished by empty input, but
previous implementation does not take into account 'CLRF' ending, and hence instead of empty string we have '\r', which is interpreted as incorrect string.
So, this commit changes default reading function to more Windows compatible reading function.

Signed-off-by: Nikita Leonov [email protected]

@nyckyta
Copy link
Author

nyckyta commented Feb 13, 2020

Seems like checker does not understand me :) I signed off commit by real name, as was mentioned in contributing recommendations, but for now checker requires my nickname.

@nyckyta nyckyta requested a review from dscho February 13, 2020 14:31
@dscho
Copy link
Member

dscho commented Feb 13, 2020

Looks good! Could you rebase onto master, though?

@nyckyta nyckyta changed the base branch from shears/maint to shears/master February 13, 2020 14:59
@nyckyta
Copy link
Author

nyckyta commented Feb 13, 2020

Looks good! Could you rebase onto master, though?

Sure, done.

@nyckyta nyckyta changed the base branch from shears/master to master February 13, 2020 15:17
@nyckyta-tmp @dscho
credential.c: fix credential reading with regards to CR/LF
d6e35b6 
This fix makes using Git credentials more friendly to Windows users. In
previous version it was unable to finish input correctly without
configuration changes (tested in PowerShell, CMD, Cygwin).

We know credential filling should be finished by empty input, but the
current implementation does not take into account CR/LF ending, and
hence instead of the empty string we get '\r', which is interpreted as
an incorrect string.

So this commit changes default reading function to a more Windows
compatible reading function.

Signed-off-by: Nikita Leonov <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Feb 13, 2020

I actually rebased the patch, and augmented the commit message in preparation for sending this off to the Git mailing list.

@dscho dscho merged commit 69c22a9 into git-for-windows:master Feb 13, 2020
git-for-windows-ci pushed a commit that referenced this pull request Feb 13, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
89289db 
credential.c: fix credential reading with regards to CR/LF
@dscho dscho mentioned this pull request Feb 13, 2020
Closed
git-for-windows-ci pushed a commit that referenced this pull request Feb 14, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
bd81c90 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 14, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
3fcc8a4 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 14, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
35f0089 
credential.c: fix credential reading with regards to CR/LF
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
14bb9c4 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
ff5db0c 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
3c5e824 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
9e7c044 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit to dscho/git that referenced this pull request Feb 17, 2020
@dscho
Merge pull request git-for-windows#2516 from nyckyta/crlf-aware-git-c…
07ea24b 
…redential

credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
2747786 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 17, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
7396483 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Feb 18, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
40f69cc 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Feb 18, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
df19072 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
fa0607a 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
7fbc2ad 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
629e58d 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 24, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
a5fa9ae 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
ec8661d 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
502dc0e 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
06399e5 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
e1f0884 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
b74addf 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
f41c93d 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
6e38fb4 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
3a5e2d3 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 27, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
0b02fee 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 27, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
ef3ab9b 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 28, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
5439b7b 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 28, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
7531504 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
a910d13 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
fdcc367 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
7185303 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
a705497 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Sep 30, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
58fa7db 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
23203ae 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
238fc08 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
41aaa4a 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
d20cbe3 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Oct 5, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
320e147 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit to dscho/git that referenced this pull request Oct 5, 2020
@dscho
Merge pull request git-for-windows#2516 from nyckyta/crlf-aware-git-c…
cf1f99c 
…redential

credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Oct 6, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
d5f458f 
credential.c: fix credential reading with regards to CR/LF
git-for-windows-ci pushed a commit that referenced this pull request Oct 7, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
f6a11d2 
credential.c: fix credential reading with regards to CR/LF
dscho added a commit that referenced this pull request Oct 20, 2020
@dscho
Merge pull request #2516 from nyckyta/crlf-aware-git-credential
ff83990 
credential.c: fix credential reading with regards to CR/LF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho Awaiting requested review from dscho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyckyta @dscho @nyckyta-tmp