Skip to content

git-artifacts: fix the time-out while trying to set up the Git for Windows SDK #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

dscho
Copy link
Member

@dscho dscho commented Jun 13, 2022

We recently fixed this in the setup-git-for-windows-sdk Action, but only in v1. We shouldn't use v0 anymore, anyway.

While at it, reword the commit message because that Action is not exactly shiny new anymore.

dscho added 2 commits June 13, 2022 23:15
Let's use v1 of that Action, which does not suffer the
infinite-until-timeout problem.

Signed-off-by: Johannes Schindelin <[email protected]>
git-artifacts: use the `setup-git-for-windows-sdk` Action

This simplifies the workflow dramatically, as well as accelerating it
because the Action recently learned to use the partial clone/parallel
checkout features of Git.

Note that we have to reinstate that `/usr/bin/git` hack (a shell script
that simply redirects to `/mingw64/bin/git.exe`) in the `pkg` job
manually, since we no longer cache the `build-installers` artifact
_after_ installing that hack in `bundle-artifacts`.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Jun 13, 2022
@dscho
Copy link
Member Author

dscho commented Jun 13, 2022

Successful git-artifacts run: https://github.com/dscho/git/actions/runs/2491244079

@dscho dscho added this to the Next release milestone Jun 13, 2022
@dscho
Copy link
Member Author

dscho commented Jun 13, 2022

The osx-* failure seems new, but also unrelated to this here PR.

@dscho dscho merged commit 1a94d3f into git-for-windows:main Jun 13, 2022
@dscho dscho deleted the fix-git-artifacts branch June 13, 2022 22:09
@dscho
Copy link
Member Author

dscho commented Jun 14, 2022

The osx-* failure seems new, but also unrelated to this here PR.

Seems that something has fixed them upstream (at least all shears/* branches pass, including the maint one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant