Site baseurl for proper asset paths #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d correctly now, yayyyyyy
|
Not sure who to approve and look at this, @matthewmccullough could you give this a quick sanity check and approval? |
|
yesssss thanks @matthewmccullough ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working off of work done in #113, i also created a
_config.ymlto have a site.baseurl that i added to most every link.I know there's a way to do this easier, but this at least fixes link.
There is one existing issue that i think i can reproduce from time to time on the
zh/site, where the existing URL stays as if it's thesite.baseurl. could approach that if we see more errors.