Skip to content

✨ Begin SQL insert with best practice #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

devlopersabbir
Copy link

issue: #64
I just improving code with best practices as I know 😅

Recap

  • OOP support on our CSV to SQL Insert
  • Terminal input (like, fileName and destination location name etc)
  • File handling hooks
  • Response handler
  • Fully readable and understandable clean code
  • String validator
    and more.... 🎁

Note: I have written "TODO" which I left for someone else to work on.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ts-node 10.9.2 filesystem +13 1.4 MB blakeembrey
nodemon 3.0.2 filesystem, shell, environment +2 240 kB remy

@devlopersabbir
Copy link
Author

@gitdagray I requested you review my code, sir...

@devlopersabbir
Copy link
Author

@jsvigneshkanna I hope this marge will help us to grow our project. what is your opinion??

@Klock85
Copy link

Klock85 commented Dec 28, 2023

I think increased code splitting like this increases the readability of the code and increases testability too

@devlopersabbir
Copy link
Author

@Klock85 thank you mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants