ci: use a newer github-script version
#1387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
upgrade-github-script-version
branch
3 times, most recently
from
cc88a32 to
dcae3f9
Compare
The old version we currently use runs in node.js v12.x, which is being deprecated in GitHub Actions. The new version uses node.js v16.x. Incidentally, this also avoids the warning about the deprecated `::set-output::` workflow command because the newer version of the `github-script` Action uses the recommended new way to specify outputs. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
upgrade-github-script-version
branch
from
dcae3f9 to
1b933c2
Compare
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
|
On the Git mailing list, Taylor Blau wrote (reply to this): On Tue, Nov 08, 2022 at 10:13:28AM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <[email protected]>
>
> The old version we currently use runs in node.js v12.x, which is being
> deprecated in GitHub Actions. The new version uses node.js v16.x.
>
> Incidentally, this also avoids the warning about the deprecated
> `::set-output::` workflow command because the newer version of the
> `github-script` Action uses the recommended new way to specify outputs.
Thanks for working on this.
I also appreciate you taking a more minimal approach by avoiding
touching the explicit "echo ::set-output::"'s throughout the workflow
definition, since there is other work going on there.
So let's merge this one down, let the dust settle on the other topic,
and then come back and remove the remaining ::set-output::'s later on.
Thanks,
Taylor |
|
User |
|
This branch is now known as |
|
This patch series was integrated into seen via git@cefc455. |
|
This patch series was integrated into next via git@5530624. |
|
This patch series was integrated into seen via git@c08655a. |
|
This patch series was integrated into seen via git@69eb1be. |
|
This patch series was integrated into master via git@69eb1be. |
|
This patch series was integrated into next via git@69eb1be. |
|
Closed via 69eb1be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the CI run of
seena couple of weeks ago and saw not only quite a number of failures but also quite a number of warnings.This patch addresses a few of them, including the ones about using the deprecated
::set-output::workflow command.Similar warnings will be addressed by
od/ci-use-checkout-v3-when-applicable.cc: Taylor Blau [email protected]