Skip to content

Missing ami_id_ssm_parameter_name parameter from multi-runner #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scatybeneva opened this issue Jan 13, 2023 · 3 comments
Closed

Missing ami_id_ssm_parameter_name parameter from multi-runner #2883

scatybeneva opened this issue Jan 13, 2023 · 3 comments

Comments

@scatybeneva
Copy link

The optional parameter ami_id_ssm_parameter_name that can be used in a single runner is not defined with the multi-runner module so it has no effect. Would be very useful to override ami_filter in the same way with multi-runner.

@npalm
Copy link
Member

npalm commented Jan 14, 2023

Here you can find an example how to overwrite the AMI including a custom user_data script

https://github.com/philips-labs/terraform-aws-github-runner/blob/a1013e91f0fe380ff7988e20e9efea78e73acea6/examples/multi-runner/main.tf#L45-L93

@scatybeneva
Copy link
Author

Yeah that works fine, but I'm talking about not using an ami_filter but to specify an SSM parameter store path to fetch the AMI ID built from an external process. This was added by this.

Looking at the code, ami_id_ssm_parameter_name isn't set in the multi-runner module. So the scale-up lambda module won't set the corresponding env var either nor the policy to allow access to the SSM parameter.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants