Skip to content

Request: Change the github.com url for GitHub Enterprise Server #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mm-matsuda opened this issue Oct 30, 2020 · 7 comments
Closed

Request: Change the github.com url for GitHub Enterprise Server #303

mm-matsuda opened this issue Oct 30, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mm-matsuda
Copy link

Hello!

Since we are using GitHub Enterprise Server, the github.com url is not available.
I want the download-lambda module to allow me to specify a url when I download a zip.

https://github.com/philips-labs/terraform-aws-github-runner/blob/5a045f555dc932459c5ed94239b3d345e9f916ba/modules/runners/lambdas/runners/src/scale-runners/scale-up.ts#L96

Cheers
@npalm npalm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 4, 2020
npalm added a commit that referenced this issue Nov 4, 2020
@npalm
Add option to set github server url #303
dd401f0
@npalm
Copy link
Member

npalm commented Nov 4, 2020

@mm-matsuda do you have time to look on the PR? I have not gh enterprise running so no option to test

npalm added a commit that referenced this issue Nov 4, 2020
@npalm
Add option to set github server url #303
2f62dc3
@WilliamDuTrendMicro
Copy link

as the GitHub EE most inside a VPC , it also need lambda working inside the VPC to conenct the GitHub EE API .

@mcaulifn
Copy link
Contributor

mcaulifn commented Dec 9, 2020

@npalm Is there a PR for this? I have GHES and can test

@npalm
Copy link
Member

npalm commented Dec 9, 2020

No PR yet, but looking for help. I made a start a few weeks ago in #303 but need to find a way the lambda's get access GHES via the API.

@mcaulifn
Copy link
Contributor

#412 opened to address this

@npalm
Copy link
Member

npalm commented Dec 21, 2020

@mcaulifn thanks, will have a look later this week

@npalm
Copy link
Member

npalm commented Jan 14, 2021

PR #412 merges, closing the issue

@npalm npalm closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mm-matsuda @npalm @mcaulifn @WilliamDuTrendMicro