Consistent naming conventions

[koendelaat]

The modules should use proper Terraform naming conventions

Currently this is not everywhere applied, e.g.:

     matcherConfig : {
       labelMatchers = [["self-hosted", "linux", "x64", "amazon"]]
       exactMatch    = false
     }
     fifo                = true
     delay_webhook_event = 0

I understand the argument of backwards compatibilty, but I think we should be able agree on some form of deprecation including proper warning/error text.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

[koendelaat]

          @koendelaat thx, maybe a good reason as to explore the module for other variables that needs to be reanamed.

Originally posted by @npalm in https://github.com/philips-labs/terraform-aws-github-runner/issues/3143#issuecomment-1500436752

I'll address this in #3143

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.