chore!: Change runner labels to list[string] and apply TFLint #3143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
4 times, most recently
from
ce093b2 to
d19a591
Compare
|
I did look at the changes and they look good. It will be good to thoroughly test this change specially around the logic to filter out the extra labels from matchers. |
|
@koendelaat thx, maybe a good reason as to explore the module for other variables that needs to be reanamed. |
Determine extra-labels based on label matchers
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
d19a591 to
4983cfd
Compare
|
Rebased commits |
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
78f4da5 to
650c3fb
Compare
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
650c3fb to
061880f
Compare
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
66685d2 to
d1963d4
Compare
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
d1963d4 to
93c9362
Compare
|
Terraform linting errors are now marked with check annotations. See: |
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
3d57800 to
ed33cf5
Compare
koendelaat
changed the title
|
@npalm Ready for review |
koendelaat
force-pushed
the
feature/multi-runner-labels
branch
from
eb6f86d to
5b9f595
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
5 tasks
|
close in favour of #3410 |
npalm
added a commit
that referenced
this pull request
Oct 19, 2023
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
npalm
added a commit
that referenced
this pull request
Oct 26, 2023
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
npalm
added a commit
that referenced
this pull request
Oct 27, 2023
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change variables
runner_labelsandrunner_extra_labelsto type:list[string]to better represent the contentAdditionally: