feat: add ami-updater lambda function with tests and config #4488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create new terraform module for ami updater lambda function - add comprehensive documentation in readme - implement all required resources including lambda, iam, eventbridge, and ssm - add variables for flexible configuration - include outputs for module integration
- implement core ami updater logic with ec2 and ssm integration - add comprehensive unit tests for all components - configure eslint and typescript for code quality - include vitest for testing framework - add aws powertools for logging and metrics - implement dry run mode for safe testing - add error handling and logging throughout
- add s3 bucket, key, and version variables for lambda deployment - make lambda zip path configurable via variable - add support for additional lambda tags - update lambda resource to handle both local and s3 deployments
- modify dist script to create zip file in dist/ami-updater.zip instead of root directory - ensure zip file location matches terraform module's expected path
…ling - update zip file location in package.json to match other modules - add ami-updater module configuration in root main.tf with consistent variable mapping - add ami_updater_lambda variables in root variables.tf for zip, memory and timeout - enable optional ami-updater functionality through enable_ami_updater variable
|
Created an PR to get the AMI ID via SSM supported via the launch template. You feedback would be very welcome. I think once we have that better done in the core. An auto update like this PR would be a welcome additon. See #4517 |
|
Hey @npalm! I’ve added a single question about your preference for using the |
npalm
added a commit
that referenced
this pull request
Apr 15, 2025
# Description This PR migrates the launch template to use SSM to foor looking up AMI ID. This PR is inteded to migrate to use SSM for AMI lookups. In later PR we will remove logic from scale-up and remove old parateters. By default, the module still uses the same AMI filters, but difference is the resulting AMI ID is stored in SSM instead of the launch template. As alternative the module user can provide `ami_id_ssm_parameter_arn` pointing to an SSM parameter containing the AMI ID to be used (data type aws:ec2:image). When using a custom managed AMI this will avoid drift in terraform when `ami.id_ssm_parameter_arn` is used instead of the deprecated `ami_id_ssm_parameter_name`. Another way to avoid the drift is to ensure the filter is poiting to the same image. See also #4460 In PR #4488 and updater via Lambda is introduced. I think we should firt think how we can better support the AMI id in the core. What this PR is supposed todo. NExt the update can be an nice way to auto update AMI's without running terraform. The PR also refactor the variables for `ami_*` and move the to a dedicated object `ami`. The old ones remains till the next major release. Deprecattion warnings are added to the output. ## Notes - Adjuest multi runner examples - Test with multi runners - Test with default runners + pool ## Fix - Deprecation warning inline_poilicy for pool --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new AMI Updater Lambda function with comprehensive configuration, testing, and infrastructure setup.
Changes
Additional Notes