Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Inspector disabled for locked files #934

Closed
vanustwo opened this issue Oct 10, 2018 · 7 comments
Closed

Inspector disabled for locked files #934

vanustwo opened this issue Oct 10, 2018 · 7 comments
Labels
bug

Comments

@vanustwo
Copy link

When a file is locked like a material. The inspector view UI is disabled. Is there a way to stop this?
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Oct 10, 2018 •
edited
Loading

Hey @vanustwo thanks for testing our stuff out and making this bug report, but can you give me a bit more to work with? Maybe a screen shot or gif or something... I'm having a bit of trouble getting what you mean.

@vanustwo
Copy link
Author

@StanleyGoldman thank you for the reply.
Repro Steps using Unity 2018.2.71 with GitHub 1.0.3

  1. Lock an existing asset like a material.
  2. The material has a lock icon.
  3. Select the locked material in the project view.
  4. The inspector for the asset become uneditable

@StanleyGoldman
Copy link
Contributor

That's real weird. I'll give it a shot myself in a bit.

@StanleyGoldman
Copy link
Contributor

I reproduced it. That's so weird.

@StanleyGoldman
Copy link
Contributor

2018-10-10_15-02-28

@vanustwo
Copy link
Author

@StanleyGoldman Do you have an ETA for a fix?

@StanleyGoldman
Copy link
Contributor

Not quite yet. I was pushing out a release yesterday and tried to see if this was an easy fix.
Unfortunately I have no idea what is causing it yet.

shana added a commit that referenced this issue Nov 7, 2018
@shana
Report the correct editing status to Unity. Fixes #934
6248aff 
There's two issues going on here

  - The `loggedInUser` field wasn't getting seeded with user information on load,
	so checking whether the current user owns a lock would always fail until the
	connections changed event got triggered somehow

  - `GetLock` didn't account for not having user information, so if the user was
	logged out, it would default to not allowing any edits. Since the info wasn't
	getting seeded, it would always report files as being locked by someone else.
	It now defaults to allowing edits if the user isn't signed in. Now, this isn't
	a bug, but if the user is not signed in, all bets are kinda off on validating
	locks. We should probably warn the user that we can't check whether they own
	the lock, but we should probably not lock down Unity entirely because of it.
StanleyGoldman added a commit that referenced this issue Nov 28, 2018
@StanleyGoldman
Merge pull request #959 from github-for-unity/fixes/934-inspector-dis…
af14cf7 
…abled

Report the correct editing status to Unity. Fixes #934
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StanleyGoldman @vanustwo