Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Updating ApplicationConfiguration webTimeout from settings #750

Merged
merged 3 commits into from
May 15, 2018
Merged

Updating ApplicationConfiguration webTimeout from settings #750

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56b2ce0
Updating ApplicationConfiguration webTimeout from settings
StanleyGoldman May 15, 2018
c4f5276
Merge branch 'master' into fixes/update-web-timeout-from-settings
StanleyGoldman May 15, 2018
b67fe9b
Update settings retrieval
StanleyGoldman May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/GitHub.Api/Application/ApplicationManagerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ protected void Initialize()
Platform = new Platform(Environment);

LogHelper.TracingEnabled = UserSettings.Get(Constants.TraceLoggingKey, false);

int webTimeout;
if (int.TryParse(UserSettings.Get(Constants.WebTimeoutKey), out webTimeout))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings will do the conversion for you - UserSettings.Get<int>(Constants.WebTimeoutKey)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

{
ApplicationConfiguration.WebTimeout = webTimeout;
}

ProcessManager = new ProcessManager(Environment, Platform.GitEnvironment, CancellationToken);
Platform.Initialize(ProcessManager, TaskManager);
GitClient = new GitClient(Environment, ProcessManager, TaskManager.Token);
Expand Down