Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support features key in version JSON output #1918

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Support features key in version JSON output #1918

merged 6 commits into from
Oct 4, 2023

Conversation

mbg
Copy link
Member

@mbg mbg commented Oct 4, 2023

Add general support for extracting the features key in the output of the version command.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@mbg mbg requested a review from a team as a code owner October 4, 2023 10:29
@mbg mbg self-assigned this Oct 4, 2023
henrymercer
henrymercer reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of minor comments.

henrymercer
henrymercer approved these changes Oct 4, 2023
View reviewed changes
@mbg mbg merged commit 3fb6719 into main Oct 4, 2023
@mbg mbg deleted the mbg/support-version-features branch October 4, 2023 16:23
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

@mbg mbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbg @henrymercer