Skip to content

Bump typescript from 4.3.5 to 4.4.2 #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2021

Bumps typescript from 4.3.5 to 4.4.2.

Release notes

Sourced from typescript's releases.

TypeScript 4.4.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.5 to 4.4.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.3.5...v4.4.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 2, 2021 17:00
@dependabot dependabot bot added the Update dependencies Trigger PR workflow to update dependencies label Sep 2, 2021
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Sep 2, 2021
@aeisenberg aeisenberg disabled auto-merge September 10, 2021 20:15
@aeisenberg aeisenberg requested review from codeql-ci, a team and aeisenberg and removed request for codeql-ci September 10, 2021 20:56
@aeisenberg
Copy link
Contributor

Can I get a review on this? I made a lot of small changes to error handling. I would like to make sure that there are no changes to how format of the error message sent to codescanning.

To be clear: if e is instanceof Error, then String(e) === e.toString() === e.name + ": " + e.message. So, new MyError('my message').toString() === 'MyError: my message'.

4.4.2 introduces a breaking change that the variable in a catch clause
is now `unknown` type. So, we need to cast the `e`, `err`, or `error`
variables to type `Error`.
@aeisenberg aeisenberg force-pushed the dependabot/npm_and_yarn/typescript-4.4.2 branch from 3ca6bd2 to 40568da Compare September 10, 2021 21:06
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@edoardopirovano edoardopirovano merged commit adfea76 into main Sep 14, 2021
@edoardopirovano edoardopirovano deleted the dependabot/npm_and_yarn/typescript-4.4.2 branch September 14, 2021 11:16
This was referenced Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants