Skip to content

Add some instructions on how to regenerate required checks #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2022
Merged

Add some instructions on how to regenerate required checks #968

merged 6 commits into from
Mar 11, 2022

Conversation

aeisenberg
Copy link
Contributor

Some instructions on how to update required checks. I hope we can fully automate this soon, and these instructions will help.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner March 8, 2022 02:39
@aeisenberg aeisenberg requested review from cklin and henrymercer March 8, 2022 02:39
henrymercer
henrymercer approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a better place for these instructions! Couple of suggestions.

@aeisenberg aeisenberg force-pushed the aeisenberg/required-checks branch from 6ddde1d to 111428c Compare March 8, 2022 18:19
@aeisenberg aeisenberg requested review from henrymercer and cklin March 8, 2022 18:19
@aeisenberg
Copy link
Contributor Author

I made some changes based on @henrymercer's suggestions. It is much simpler now and it's now possible to convert this into an automated action more easily.

henrymercer
henrymercer reviewed Mar 9, 2022
View reviewed changes
@aeisenberg aeisenberg enabled auto-merge March 10, 2022 17:20
henrymercer
henrymercer reviewed Mar 11, 2022
View reviewed changes
@henrymercer henrymercer disabled auto-merge March 11, 2022 16:22
henrymercer
henrymercer reviewed Mar 11, 2022
View reviewed changes
@aeisenberg aeisenberg enabled auto-merge March 11, 2022 19:43
@aeisenberg aeisenberg merged commit 761da7e into main Mar 11, 2022
@aeisenberg aeisenberg deleted the aeisenberg/required-checks branch March 11, 2022 20:11
@github-actions github-actions bot mentioned this pull request Mar 15, 2022
Merged
5 tasks
This was referenced Jul 7, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

@cklin cklin cklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeisenberg @cklin @henrymercer