Skip to content

Swift: add RNCryptor sinks to swift/static-initialization-vector #11942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jan 20, 2023

Add RNCryptor sinks to swift/static-initialization-vector. This PR is related to #11905 and others.

I have also extended the sources for this query to cover more types of constants. I think once all four RNCryptor PRs are merged, I will go back and try to make the sources more consistent between these similar queries.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Jan 20, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner January 20, 2023 15:29
@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 25, 2023

The DCA run looks good to me.

Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 27, 2023

Thanks for reviewing!

@geoffw0 geoffw0 merged commit 794ba42 into github:main Jan 27, 2023
@geoffw0 geoffw0 deleted the rncrypt4 branch March 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants