Skip to content

ruby: add rb/useless-assignment-to-local to the code-quality suite #19230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Apr 7, 2025

This PR adds the query rb/useless-assignment-to-local to the code-quality suite.
The query was improved in #19164 to the point of increasing its precision.
It has been triaged locally and both results and fixes were found to be reasonable.

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 12:11
@yoff yoff requested a review from a team as a code owner April 7, 2025 12:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • ruby/ql/src/codeql-suites/ruby-code-quality.qls: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@github-actions github-actions bot added the Ruby label Apr 7, 2025
@yoff yoff merged commit bf7d3d1 into github:main Apr 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants