README language pedantry #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
force-pushed
the
readme-pedantry
branch
from
5ffc412 to
ebd27d8
Compare
jbj
pushed a commit
that referenced
this pull request
Apr 11, 2019
We avoid putting a variable into SSA if its address is ever taken in a way that could allow mutation of the variable via indirection. We currently just look to see if the address is either "pointer to non-const" or "reference to non-const". However, if the address was cast to an integral type (e.g. `uintptr_t n = (uintptr_t)&x;`), we were treating it as unescaped. This change makes the conservative assumption that casting a pointer to an integer may result in the pointed-to value being modified later. This fixes a customer-reported false positive (#2 from https://discuss.lgtm.com/t/2-false-positives-in-c-for-comparison-is-always-same/1943)
geoffw0
pushed a commit
that referenced
this pull request
May 29, 2019
CPP: Minor corrections to: Better overflow detection for AssignAdd/AssignSub
semmle-qlci
pushed a commit
that referenced
this pull request
May 30, 2019
JavaScript: Update expected test output.
jbj
pushed a commit
that referenced
this pull request
Jan 29, 2020
Documentation update for Issue #2623
aschackmull
pushed a commit
that referenced
this pull request
Jun 19, 2020
Dataflow: Record content types
aschackmull
pushed a commit
that referenced
this pull request
Jul 8, 2020
Java: Fix qltests for #3653
yoff
pushed a commit
that referenced
this pull request
Oct 20, 2020
…efinition Python: Add test for tricky module member for type-tracking
max-schaefer
pushed a commit
to max-schaefer/codeql
that referenced
this pull request
Mar 23, 2021
Reintroduce type definitions to API graphs
owen-mc
referenced
this pull request
in owen-mc/codeql
Jun 25, 2021
smowton
referenced
this pull request
in smowton/codeql
Oct 28, 2021
Kotlin: Don't make a *Kt class unless we need one
hvitved
added a commit
that referenced
this pull request
Nov 18, 2021
This is in order to avoid name clash with the often so-named IPA type for data- flow nodes. The name clash is not problematic because they are both in scope, but because (cached) IPA types with overlapping names are known to sometimes result in re-evaluation of cached stages, when one of the IPA types gets an internal `#2` suffix in one query run, and the other IPA type gets the suffix in another run.
hohn
referenced
this pull request
in hohn/codeql
Dec 13, 2021
Java: Add link to prebuilt Struts databases
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
tiferet
added a commit
that referenced
this pull request
Aug 3, 2022
Feature selection: Use a shipping model with the new features excluding fileImports and calleeImports. Model #2. github/ml-ql-adaptive-threat-modeling#1968 (comment)
tiferet
added a commit
that referenced
this pull request
Sep 7, 2022
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #2 https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479760_3a49ddf5?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
tiferet
added a commit
that referenced
this pull request
Sep 19, 2022
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #2 (with a fixed package version) https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479760_3a49ddf5?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
hvitved
added a commit
that referenced
this pull request
Oct 10, 2022
DIL before
```
/* AST::AstNode */ AST#87953007::Cached::TAstNode result) =
fastTC(AST#a6718388::AstNode::getAChild#0#dispred#ff/2)
.
Synthesis#d9ff06b1::isInDesugaredContext#1#f(/* AST::AstNode */ unique AST#87953007::Cached::TAstNode n)
:-
exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ |
arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n)
);
exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode call_result#2 |
exists(int arg1,
/* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ |
arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, call_result#2)
),
#AST#a6718388::AstNode::getAChild#0#dispredPlus#ff(call_result#2, n)
)
.
```
DIL after
```
incremental
Synthesis#d9ff06b1::isInDesugaredContext#1#f(/* AST::AstNode */ unique AST#87953007::Cached::TAstNode n)
:-
exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ |
arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n)
);
exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode any#expr##2 |
rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(any#expr##2),
exists(cached dontcare string _ |
AST#a6718388::AstNode::getAChild#1#dispred(any#expr##2, _, n)
)
)
| [base_case]
exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ |
arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n)
)
| [delta_order]
exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode any#expr##2 |
delta previous rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(any#expr##2),
project#AST#a6718388::AstNode::getAChild#1#dispred(any#expr##2, n)
),
not(previous rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(n))
.
``
owen-mc
added a commit
that referenced
this pull request
Jul 12, 2023
…used-parameters-2 Go: make `ParameterNode`s for unused parameters #2 (make a disjoint class for unused ones)
jketema
pushed a commit
that referenced
this pull request
Sep 5, 2024
C++: Fix zstd and clean up test
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Refactor CfgScopes and Ast predicate names
owen-mc
added a commit
that referenced
this pull request
Mar 25, 2025
Go: Add database source models for the github.com/couchbase/gocb package (#2)
owen-mc
added a commit
that referenced
this pull request
Mar 27, 2025
Go: Add `database` source models for the `squirrel` package (#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.