Skip to content

feat(types): add filter-input to HTMLElementTagNameMap #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

nberlette
Copy link
Contributor

@nberlette nberlette commented Apr 17, 2023

This PR adds filter-input to the global HTMLElementTagNameMap interface.

This is essentially the type-level equivalent of adding the tag to the global registry.

Since it is now a globally-recognized element, it's treated as a first class citizen in
the DOM, receiving full type support when using <filter-input> directly in your code,
or adding event listeners, and so on.

Note: today I learned that renaming a branch after opening a PR immediately closes that PR. Sorry for the dupe 😞

Adding `filter-input` to the global `HTMLElementTagNameMap` interface is the type-level equivalent of registering the tag in the global registry. Since it is now recognized as a globally-available element, it enables stronger types when using `<filter-input>` directly, or adding event listeners, etc.
@nberlette nberlette requested a review from a team as a code owner April 17, 2023 12:55
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit a2cc735 into github:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants