feat: partition tools by product/feature #188

SamMorrowDrums · 2025-04-08T23:45:19Z

Partitioned Features

This PR proposes a method for partitioning features by product area, and provides ENV and CLI flag options to configure it on server startup.

Features Configuration

The GitHub MCP Server supports enabling or disabling specific groups of functionalities via the --features flag. This allows you to control which GitHub API capabilities are available to your AI tools.

Available Features

The following feature groups are available:

Feature	Description	Default Status
`repos`	Repository-related tools (file operations, branches, commits)	Enabled
`issues`	Issue-related tools (create, read, update, comment)	Enabled
`search`	Search functionality (code, repositories, users)	Enabled
`pull_requests`	Pull request operations (create, merge, review)	Enabled
`code_security`	Code scanning alerts and security features	Disabled
`experiments`	Experimental features (not considered stable)	Disabled
`everything`	Special flag to enable all features	Disabled

Specifying Features

You can enable specific features in two ways:

Using Command Line Argument:

github-mcp-server --features repos,issues,pull_requests,code_security

Using Environment Variable:

GITHUB_FEATURES="repos,issues,pull_requests,code_security" ./github-mcp-server

The environment variable GITHUB_FEATURES takes precedence over the command line argument if both are provided.

Default Enabled Features

By default, the following features are enabled:

repos
issues
pull_requests
search

Using With Docker

When using Docker, you can pass the features as environment variables:

docker run -i --rm \
  -e GITHUB_PERSONAL_ACCESS_TOKEN=<your-token> \
  -e GITHUB_FEATURES="repos,issues,pull_requests,code_security,experiments" \
  ghcr.io/github/github-mcp-server

The "everything" Feature

The special feature everything can be provided to enable all available features regardless of their individual settings:

./github-mcp-server --features everything

Or using the environment variable:

GITHUB_FEATURES="everything" ./github-mcp-server

Copilot

Pull Request Overview

This PR partitions the GitHub MCP Server tools by product area using feature flags, and adds the necessary configuration options and tests.

Introduces a new "features" module to manage feature sets and enable/disable specific tools.
Updates the server initialization to conditionally add tools based on feature flags.
Adds tests and updates documentation to reflect the new configurable features.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/github/server_test.go	Added tests (e.g., Test_ListAvailableFeatures) for verifying the feature listing tool.
pkg/github/server.go	Modified server creation to conditionally add tools based on enabled feature flags.
pkg/features/features_test.go	Added unit tests to validate FeatureSet behavior.
pkg/features/features.go	Introduced FeatureSet implementation for feature management.
cmd/github-mcp-server/main.go	Updated CLI and environment variable parsing to initialize features.
README.md	Expanded documentation on the new features configuration and usage.

Comments suppressed due to low confidence (2)

cmd/github-mcp-server/main.go:91

[nitpick] Consider renaming the variable 'envFeats' to 'envFeatures' to improve clarity.

if envFeats := os.Getenv("GITHUB_FEATURES"); envFeats != "" {

pkg/features/features.go:63

[nitpick] Consider wrapping the feature name in quotes within the error message (e.g. "feature '%s' does not exist") for improved clarity.

return fmt.Errorf("feature %s does not exist", name)

Copilot · 2025-04-08T23:45:54Z

pkg/github/server.go

+		func(_ context.Context, _ mcp.CallToolRequest) (*mcp.CallToolResult, error) {
+			// We need to convert the FeatureSet back to a map for JSON serialization
+			featureMap := make(map[string]bool)
+			for name := range featureSet.Features {


If a deterministic order of features is required for clients consuming the JSON output, consider sorting the feature keys before JSON marshaling.

mntlty · 2025-04-09T00:04:39Z

pkg/features/features.go

+	}
+}
+
+func (fs *FeatureSet) AddFeature(name string, description string, enabled bool) {


Nit: if you ever need to use https://pkg.go.dev/io/fs in here one or the other will need to be renamed

Great point!

toby · 2025-04-09T00:35:50Z

I might consider calling them "toolsets" instead of features, just to be a bit more explicit.

SamMorrowDrums · 2025-04-09T01:40:14Z

@toby toolsets does make sense, I hesitate a little because resources and prompts are also part of it, so I was sort of avoiding the word tool, but perhaps we just run with it?

Definitely not committed to any naming.

juruen

Looks good to me!

Just one super minor question: what would you think about using all instead of everything?

As it's very minor, feel free to ignore it 😄

toby · 2025-04-10T17:35:11Z

This is so great!!

tonytrg · 2025-04-10T18:40:09Z

Aside from the linter, do you plan on merging this soon?

SamMorrowDrums · 2025-04-10T18:42:22Z

Yeah, I just have to finish a couple of bits. Mostly the auto tool updates. Just keep pushing the latest.

juruen

Looking great! 🚀

toby · 2025-04-11T17:09:59Z

What do you think about these options?

By default we list all tools (all), except: list_available_toolsets, enable_toolset and get_toolset_tools since you won't really need them with all enabled.
Use a --dynamic-toolsets flag to enable list_available_toolsets, enable_toolset and get_toolset_tools, all other tools (except get_me) are hidden until enabled
Use the --toolsets flag to specify active toolsets. If used in conjunction with --dynamic-toolsets they will be hidden until enabled, toolsets not specified, cannot be enabled. If the --dynamic-toolsets flag is not set, all of the tools listed in the toolsets you've enabled are listed by default.

SamMorrowDrums · 2025-04-12T17:55:37Z

I think those suggestions get us closer to a usable interface for sure, will riff on them on Monday I hope, see if we end up with something mergeable. Feels close.

cmd/github-mcp-server/main.go

pkg/github/tools.go

williammartin · 2025-04-14T09:19:03Z

README.md

+- `issues`
+- `pull_requests`
+- `search`
+- `context-_ools`


williammartin · 2025-04-14T09:24:17Z

pkg/toolsets/toolsets.go

+	readOnly          bool
+	writeTools        []server.ServerTool
+	readTools         []server.ServerTool
+	resourceTemplates []ResourceTemplate


Feedback

Was a bit confusing to me that toolsets also manage resource templates. I don't see a relationship between them. Might be indicative that the abstraction is trying to do too much.

I'll leave it separate then, initially the idea was that all features pertaining to a product area (not just tools) would be adjusted - and the naming reflected that - but I merged it into toolsets.

For now I'll leave it separate, and it can be revisited.

ismith · 2025-04-14T22:08:51Z

"none" also might be useful? As in, "I do not currently want any of these tools enabled, but nor do I want to remove my config entirely from settings" (and since .vscode/mcp.json is, well, json, commenting out the entire block seems like a non-starter).

SamMorrowDrums · 2025-04-14T22:33:47Z

Interesting idea @ismith

commenting out the entire block seems like a non-starter
Actually VSCode config supports jsonc, so you can use comments, and also you can de-select the tools for an entire server in the UI, if you click on the symbol.

Some other software might not support that, but I'm tempted to say we once this merges we could track the none idea in an issue if you like, and see if there are others requesting the same?

Copilot AI review requested due to automatic review settings April 8, 2025 23:45

Copilot AI reviewed Apr 8, 2025

View reviewed changes

SamMorrowDrums force-pushed the partition-tools branch from 4141d2f to ed61afc Compare April 8, 2025 23:46

SamMorrowDrums mentioned this pull request Apr 8, 2025

RFC: Partitioning tools by product/feature #189

Closed

mntlty reviewed Apr 9, 2025

View reviewed changes

Adam-it mentioned this pull request Apr 9, 2025

Tools management - how VS Code GitHub Copilot Agent will react to 700+ tools Adam-it/microsoft-365-mcp-server#1

Open

juruen previously approved these changes Apr 10, 2025

View reviewed changes

SamMorrowDrums dismissed juruen’s stale review via 3f38134 April 10, 2025 16:17

SamMorrowDrums force-pushed the partition-tools branch from ed61afc to 3f38134 Compare April 10, 2025 16:17

SamMorrowDrums requested review from williammartin and toby as code owners April 10, 2025 16:17

SamMorrowDrums force-pushed the partition-tools branch from 3f38134 to b0bcb21 Compare April 10, 2025 16:24

toby previously approved these changes Apr 10, 2025

View reviewed changes

tonytrg previously approved these changes Apr 10, 2025

View reviewed changes

SamMorrowDrums dismissed stale reviews from tonytrg and toby via d2588f0 April 10, 2025 23:51

SamMorrowDrums force-pushed the partition-tools branch 2 times, most recently from 0ee52f5 to 9a56c25 Compare April 11, 2025 00:15

juruen previously approved these changes Apr 11, 2025

View reviewed changes

SamMorrowDrums dismissed juruen’s stale review via 9d0c8cf April 11, 2025 13:31

SamMorrowDrums force-pushed the partition-tools branch 5 times, most recently from 8d56fe2 to 6ecee2f Compare April 11, 2025 14:10

SamMorrowDrums requested a review from juruen April 11, 2025 15:22

williammartin reviewed Apr 14, 2025

View reviewed changes

cmd/github-mcp-server/main.go Show resolved Hide resolved

pkg/github/tools.go Show resolved Hide resolved

williammartin reviewed Apr 14, 2025

View reviewed changes

README.md Outdated

- `issues`

- `pull_requests`

- `search`

- `context-_ools`

Copy link

Collaborator

williammartin Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

williammartin reviewed Apr 14, 2025

View reviewed changes

SamMorrowDrums force-pushed the partition-tools branch 2 times, most recently from 45f55fc to 8aba085 Compare April 14, 2025 21:04

feat: partition tools by product/feature

Loading
Loading status checks…

1dea445

SamMorrowDrums force-pushed the partition-tools branch from 8aba085 to 1dea445 Compare April 14, 2025 22:59

SamMorrowDrums merged commit ff3036d into main Apr 14, 2025
16 checks passed

SamMorrowDrums deleted the partition-tools branch April 14, 2025 23:11

joshmgross mentioned this pull request Apr 15, 2025

Add support for running an Actions workflow #269

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: partition tools by product/feature #188

feat: partition tools by product/feature #188

SamMorrowDrums commented Apr 8, 2025 •

edited

Loading

Copilot AI left a comment

Copilot AI Apr 8, 2025

mntlty Apr 9, 2025

SamMorrowDrums Apr 9, 2025

toby commented Apr 9, 2025

SamMorrowDrums commented Apr 9, 2025

juruen left a comment •

edited

Loading

toby commented Apr 10, 2025

tonytrg commented Apr 10, 2025

SamMorrowDrums commented Apr 10, 2025

juruen left a comment

toby commented Apr 11, 2025

SamMorrowDrums commented Apr 12, 2025

williammartin Apr 14, 2025

williammartin Apr 14, 2025

SamMorrowDrums Apr 14, 2025

ismith commented Apr 14, 2025

SamMorrowDrums commented Apr 14, 2025

feat: partition tools by product/feature #188

feat: partition tools by product/feature #188

Conversation

SamMorrowDrums commented Apr 8, 2025 • edited Loading

Partitioned Features

Features Configuration

Available Features

Specifying Features

Default Enabled Features

Using With Docker

The "everything" Feature

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

mntlty Apr 9, 2025

Choose a reason for hiding this comment

SamMorrowDrums Apr 9, 2025

Choose a reason for hiding this comment

toby commented Apr 9, 2025

SamMorrowDrums commented Apr 9, 2025

juruen left a comment • edited Loading

Choose a reason for hiding this comment

toby commented Apr 10, 2025

tonytrg commented Apr 10, 2025

SamMorrowDrums commented Apr 10, 2025

juruen left a comment

Choose a reason for hiding this comment

toby commented Apr 11, 2025

SamMorrowDrums commented Apr 12, 2025

williammartin Apr 14, 2025

Choose a reason for hiding this comment

williammartin Apr 14, 2025

Choose a reason for hiding this comment

SamMorrowDrums Apr 14, 2025

Choose a reason for hiding this comment

ismith commented Apr 14, 2025

SamMorrowDrums commented Apr 14, 2025

SamMorrowDrums commented Apr 8, 2025 •

edited

Loading

juruen left a comment •

edited

Loading