-
Notifications
You must be signed in to change notification settings - Fork 556
Optimize Docker build with bind mounts #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Juneezee
wants to merge
3
commits into
github:main
Choose a base branch
from
Juneezee:docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−12
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
.github | ||
.vscode | ||
script | ||
third-party | ||
.dockerignore | ||
.gitignore | ||
**/*.yml | ||
**/*.yaml | ||
**/*.md | ||
**/*_test.go | ||
LICENSE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,26 @@ | ||
FROM golang:1.23.7-alpine AS build | ||
ARG VERSION="dev" | ||
|
||
FROM golang:1.23.7 AS build | ||
# allow this step access to build arg | ||
ARG VERSION | ||
# Set the working directory | ||
WORKDIR /build | ||
|
||
RUN go env -w GOMODCACHE=/root/.cache/go-build | ||
# Install git | ||
RUN --mount=type=cache,target=/var/cache/apk \ | ||
apk add git | ||
|
||
# Install dependencies | ||
COPY go.mod go.sum ./ | ||
RUN --mount=type=cache,target=/root/.cache/go-build go mod download | ||
|
||
COPY . ./ | ||
# Build the server | ||
RUN --mount=type=cache,target=/root/.cache/go-build CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \ | ||
-o github-mcp-server cmd/github-mcp-server/main.go | ||
# go build automatically download required module dependencies to /go/pkg/mod | ||
RUN --mount=type=cache,target=/go/pkg/mod \ | ||
--mount=type=cache,target=/root/.cache/go-build \ | ||
--mount=type=bind,target=. \ | ||
CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \ | ||
-o /bin/github-mcp-server cmd/github-mcp-server/main.go | ||
|
||
# Make a stage to run the app | ||
FROM gcr.io/distroless/base-debian12 | ||
# Set the working directory | ||
WORKDIR /server | ||
# Copy the binary from the build stage | ||
COPY --from=build /build/github-mcp-server . | ||
COPY --from=build /bin/github-mcp-server . | ||
# Command to run the server | ||
CMD ["./github-mcp-server", "stdio"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size of
GOMODCACHE
withgo mod download
:Size of
GOMODCACHE
withgo build
:Running
go build
results in a smallerGOMODCACHE
(~80 MB) compared togo mod download
(~186 MB). I found a great explanation on StackOverflow here: https://stackoverflow.com/a/68172023/7902371The
go build
step took 19.1 seconds, which is 2 seconds faster thango mod download
(4.1 seconds) +go build
(17.1 seconds).