Document add_sub_issue tool functionality #235
+627
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryasoni98
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
|
@juruen @SamMorrowDrums @williammartin @toby Please review my PR . |
|
Thank you for your work. We have an upcoming PR that will require some changes to how tools are added to the server due to merge soon, and it will help to resolve issues with too many tools, so we appreciate your patience. We will resume merging new tools a bit faster after that, where they are a good fit. Sub-issues is definitely a powerful thing to add and that's not lost on us. I presume you can use your fork if you need this feature in the meantime. |
Comment on lines
+30
to
+89
| // Add GitHub Resources | ||
| s.AddResourceTemplate(GetRepositoryResourceContent(getClient, t)) | ||
| s.AddResourceTemplate(GetRepositoryResourceBranchContent(getClient, t)) | ||
| s.AddResourceTemplate(GetRepositoryResourceCommitContent(getClient, t)) | ||
| s.AddResourceTemplate(GetRepositoryResourceTagContent(getClient, t)) | ||
| s.AddResourceTemplate(GetRepositoryResourcePrContent(getClient, t)) | ||
|
|
||
| // Add GitHub tools - Issues | ||
| s.AddTool(GetIssue(getClient, t)) | ||
| s.AddTool(SearchIssues(getClient, t)) | ||
| s.AddTool(ListIssues(getClient, t)) | ||
| s.AddTool(GetIssueComments(getClient, t)) | ||
| s.AddTool(GetSubIssues(getClient, t)) | ||
| if !readOnly { | ||
| s.AddTool(CreateIssue(getClient, t)) | ||
| s.AddTool(AddIssueComment(getClient, t)) | ||
| s.AddTool(UpdateIssue(getClient, t)) | ||
| s.AddTool(AddSubIssue(getClient, t)) | ||
| } | ||
|
|
||
| // Add GitHub tools - Pull Requests | ||
| s.AddTool(GetPullRequest(getClient, t)) | ||
| s.AddTool(ListPullRequests(getClient, t)) | ||
| s.AddTool(GetPullRequestFiles(getClient, t)) | ||
| s.AddTool(GetPullRequestStatus(getClient, t)) | ||
| s.AddTool(GetPullRequestComments(getClient, t)) | ||
| s.AddTool(GetPullRequestReviews(getClient, t)) | ||
| if !readOnly { | ||
| s.AddTool(MergePullRequest(getClient, t)) | ||
| s.AddTool(UpdatePullRequestBranch(getClient, t)) | ||
| s.AddTool(CreatePullRequestReview(getClient, t)) | ||
| s.AddTool(CreatePullRequest(getClient, t)) | ||
| s.AddTool(UpdatePullRequest(getClient, t)) | ||
| s.AddTool(AddPullRequestReviewComment(getClient, t)) | ||
| } | ||
|
|
||
| // Add GitHub tools - Repositories | ||
| s.AddTool(SearchRepositories(getClient, t)) | ||
| s.AddTool(GetFileContents(getClient, t)) | ||
| s.AddTool(GetCommit(getClient, t)) | ||
| s.AddTool(ListCommits(getClient, t)) | ||
| s.AddTool(ListBranches(getClient, t)) | ||
| if !readOnly { | ||
| s.AddTool(CreateOrUpdateFile(getClient, t)) | ||
| s.AddTool(CreateRepository(getClient, t)) | ||
| s.AddTool(ForkRepository(getClient, t)) | ||
| s.AddTool(CreateBranch(getClient, t)) | ||
| s.AddTool(PushFiles(getClient, t)) | ||
| } | ||
|
|
||
| // Add GitHub tools - Search | ||
| s.AddTool(SearchCode(getClient, t)) | ||
| s.AddTool(SearchUsers(getClient, t)) | ||
|
|
||
| // Add GitHub tools - Users | ||
| s.AddTool(GetMe(getClient, t)) | ||
|
|
||
| // Add GitHub tools - Code Scanning | ||
| s.AddTool(GetCodeScanningAlert(getClient, t)) | ||
| s.AddTool(ListCodeScanningAlerts(getClient, t)) |
There was a problem hiding this comment.
I think your merge was bad here unfortunately, tool initialisation is now in tools.go the change was quite big, so apologies for the extra work, but it's probably best to drop the merge commit and rebase with main again, and be careful about resolving the merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #196