Skip to content

Invalid heading level generation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muan opened this issue Sep 24, 2019 · 0 comments · Fixed by #24
Closed

Invalid heading level generation #23

muan opened this issue Sep 24, 2019 · 0 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@muan
Copy link
Contributor

muan commented Sep 24, 2019

From #20. Reference: https://spec.commonmark.org/0.29/#example-33

More than six # characters is not a heading

Here's an example test for this:

it('does not insert header for invalid level', function() {
  setVisualValue('|title|')
  clickToolbar('md-header[level="10"]')
  assert.equal('|title|', visualValue())
})
FAILED TESTS:
  markdown-toolbar-element
    after tree insertion
      header
        ✖ does not insert header for invalid level
          HeadlessChrome 76.0.3809 (Mac OS X 10.14.6)
        AssertionError: expected '|title|' to equal '########## |title|'
            at Context.<anonymous> (test.js:509:16)

cc @mintbridge @koddsson

@muan muan added the bug Something isn't working label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant