Skip to content

add attribute support for setting the heading level #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

mintbridge
Copy link
Contributor

Hi,

I'll tidy this up and add tests/docs but wanted to get thoughts on adding attribute support for setting the heading level instead of it always being h3 (###). Example usage:

<md-header level="1">h1</md-header>
<md-header level="6">h6</md-header>

Paul

Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✨ Thanks for the PR!

@koddsson koddsson merged commit f561560 into github:master Sep 24, 2019
@koddsson
Copy link
Contributor

Released in v1.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants