Fix large sarif handling #1004
Merged
Fix large sarif handling #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcnjaramillo
force-pushed
the
fix-large-sarif-handling
branch
from
0c07819 to
59682d4
Compare
6 tasks
aeisenberg
reviewed
Nov 16, 2021
|
I think the test failures are because you are using an older version of npm. Could you try upgrading to version 8? And then try re-running npm install. |
|
Actually, try rebasing on this PR #1003 The problem is that for some reason, fsevents is not marked as optional. |
aeisenberg
reviewed
Nov 17, 2021
|
|
||
| it('should throw an error if the file fails to parse', async () => { | ||
| const result = await CodeQLCliServer.parseSarif(__dirname + '/data/sarif/invalidSarif.sarif'); | ||
| await expect(result).to.rejectedWith(/Error: Parsing output of interpretation failed: /); |
There was a problem hiding this comment.
Semantics are the same, but reads a little nicer.
Suggested change
| await expect(result).to.rejectedWith(/Error: Parsing output of interpretation failed: /); | |
| await expect(result).to.be.rejectedWith(/Error: Parsing output of interpretation failed: /); |
| describe.only('cliServerTests', () => { | ||
| it('should parse a valid SARIF file', async () => { | ||
| const result = await CodeQLCliServer.parseSarif(__dirname + '/data/sarif/validSarif.sarif'); | ||
| expect(result.runs.length).to.eq(1); |
There was a problem hiding this comment.
I think you want a different expectation here.
There was a problem hiding this comment.
I updated this. Hopefully it's a better test.
marcnjaramillo
force-pushed
the
fix-large-sarif-handling
branch
from
9369f77 to
fe40ebf
Compare
Authored by: Marc Jaramillo [email protected] Authored by: Musab Guma'a [email protected]
marcnjaramillo
force-pushed
the
fix-large-sarif-handling
branch
from
fe40ebf to
ca5e5e2
Compare
aeisenberg
reviewed
Nov 19, 2021
aeisenberg
reviewed
Nov 20, 2021
extensions/ql-vscode/src/vscode-tests/no-workspace/sarifParser.test.ts
Outdated
Show resolved
Hide resolved
asfgit
pushed a commit
to apache/ofbiz-framework
that referenced
this pull request
Nov 23, 2021
…s (OFBIZ-12361) According to github/vscode-codeql#1004 github/vscode-codeql#735 this should now work. Let's try...
asfgit
pushed a commit
to apache/ofbiz-framework
that referenced
this pull request
Nov 23, 2021
…s (OFBIZ-12361) According to github/vscode-codeql#1004 github/vscode-codeql#735 this should now work. Let's try...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this with a description of the changes your pull request makes.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.