Skip to content

Move MRVA out of canary #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2023
Merged

Move MRVA out of canary #2121

merged 4 commits into from
Mar 1, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Feb 28, 2023

Changes the extension so that it no longer requires users to be in the canary channel to use multi-repository variant analysis.

It might be easier if this is reviewed commit by commit.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Feb 28, 2023
@charisk charisk requested review from a team as code owners February 28, 2023 14:11
robertbrignull
robertbrignull reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing it too and it seems to be working for me. I have the canary flag disabled and I can still do all the MRVA-related actions that I can think of.

@charisk charisk force-pushed the charisk/mrva-public-beta branch from fd98204 to ff0425d Compare February 28, 2023 15:02
@robertbrignull
Copy link
Contributor

The code scanning alert is not a new alert, but an existing alert that happens to appear in the diff. We can ignore it for now.

@charisk charisk closed this Mar 1, 2023
@charisk charisk reopened this Mar 1, 2023
@charisk charisk merged commit 56d283f into main Mar 1, 2023
@charisk charisk deleted the charisk/mrva-public-beta branch March 1, 2023 09:55
This was referenced Mar 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
secexp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @robertbrignull