fix syntax highlighting after imports with instantiation arguments

[ginsbach]

Fixes https://github.com/github/codeql-core/issues/3697

This PR updates the TextMate grammar to allow instantiation arguments in import statements. This will improve syntax highlighting. Specifically, It is meant to fix the highlighting of pragma in the example below.

Note that I don't know the TextMate grammar world very well, so am not really sure whether what I did here makes any sense.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[robertbrignull]

Sorry I don't think I'm qualified to review this properly, so hopefully someone with more experience of this area can help.

I did notice that the following files were accidentally committed. Could you remove them please

• extensions/.DS_Store
• extensions/ql-vscode/.DS_Store
• extensions/ql-vscode/test/.DS_Store
• extensions/ql-vscode/test/common/.DS_Store

[shati-patel]

Thanks for the edits! Looks good from an admin point-of-view, but it would be great to get a look from someone who knows about textmate 😅

[dbartol]

This seems to be fixing the highlighting of the #pragma, but I don't think it's actually highlighting the instantiation as part of the import-directive node. I think I've got an idea of how to fix it differently. I'll propose some changes in a bit.

Protip: The VS Code command Developer: Inspect Editor Tokens and Scopes lets you see exactly how the grammar tagged the character at the current cursor position.

[dbartol]

@ginsbach I just opened #2859, which targets your PR branch, with a suggested alternate fix.

[ginsbach]

@ginsbach I just opened #2859, which targets your PR branch, with a suggested alternate fix.

Thank you! I have added the relevant commit to this PR and rebased on main to resolve the changelog conflict.

[dbartol]

LGTM

[ginsbach]

I have rebased on main to remove the merge conflict in the changelog.