Skip to content

Move modeling events to new ModelingEvents class #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Move modeling events to new ModelingEvents class #3005

merged 1 commit into from
Oct 23, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Oct 20, 2023

As part of the method modeling panel work, we introduced a new ModelingStore that is used to hold state around modeling and publishing events that the various panels subscribe to. The events are currently part of the ModelingStore.

In this PR we introduce a new ModelingEvents class and move all the events there. In the future, we can have UI interactions also represented by events.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner October 20, 2023 15:49
koesie10
koesie10 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit 1ab198f into main Oct 23, 2023
@charisk charisk deleted the charisk/introduce-modeling-events branch October 23, 2023 07:57
@charisk charisk mentioned this pull request Oct 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @koesie10