Skip to content

Rename "allowHttp" setting #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

Rename "allowHttp" setting #3069

merged 2 commits into from
Nov 14, 2023

Conversation

shati-patel
Copy link
Contributor

Follow up to #3047 to properly rename this setting and deprecate the old name!

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel
Rename "allowHttp" setting
ed84bf0 
Both names will be supported for a few releases, then we'll remove the old name.
@shati-patel
Update changelog
b45c44a
@shati-patel shati-patel marked this pull request as ready for review November 14, 2023 11:31
@shati-patel shati-patel requested a review from a team as a code owner November 14, 2023 11:31
charisk
charisk approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shati-patel shati-patel enabled auto-merge (squash) November 14, 2023 11:33
@shati-patel shati-patel merged commit 1440339 into main Nov 14, 2023
@shati-patel shati-patel deleted the shati-patel/rename-setting branch November 14, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shati-patel @charisk