Skip to content

unsubscribe does not change subscription status for me #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
budparr opened this issue Jun 24, 2020 · 7 comments · Fixed by #517
Closed

unsubscribe does not change subscription status for me #421

budparr opened this issue Jun 24, 2020 · 7 comments · Fixed by #517

Comments

@budparr
Copy link

budparr commented Jun 24, 2020

V3.0.5, tested on v3.1.0 as well

Hi. I love the new unsubscribe button. It doesn't unsubscribe me from an issue though. After I click on the unsubscribe button, the issue disappears as I would expect, but if there's new activity on the issue it appears in Gitify again as if I did nothing. If I look at an issue I've unsubscribed from in Gitify, Github's button still indicates I can unsubscribe (indicating I'm still subscribed).

I've logged out of Gitify and re-authenticated, but it still have the issue.

I'm on Mac/Catalina 10.15.5

@budparr budparr changed the title unsubscribe does not work for me unsubscribe does not change subscription status for me Jun 26, 2020
@talyguryn
Copy link

same problem

gitify v4.1.0
macOS 10.15.7

@JakeSidSmith
Copy link
Collaborator

Hmm, the request seems to just ignore the notification.

Request:

Screenshot 2021-01-08 at 09 00 23

Screenshot 2021-01-08 at 08 57 22

Response:

Screenshot 2021-01-08 at 08 57 31

I think what we need is to delete the subscription: https://docs.github.com/en/free-pro-team@latest/rest/reference/activity#delete-a-thread-subscription

@JakeSidSmith
Copy link
Collaborator

@talyguryn
Copy link

@JakeSidSmith yea, at this moment "mute" button do the same as "mark as read".

looks like 'delete' method will fix this issue.

@talyguryn
Copy link

@manosim any updates or ideas?

@Juice805
Copy link
Contributor

Same issue. Would be a huge QoL improvement to be able to unsubscribe

@Juice805
Copy link
Contributor

Looks they were trying to use this endpoint but it should be ignored, rather than ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants