Skip to content

fix: unsubscribe button ignoring thread subscription #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix: unsubscribe button ignoring thread subscription #517

merged 1 commit into from
Sep 28, 2021

Conversation

Juice805
Copy link
Contributor

@Juice805 Juice805 commented Sep 27, 2021 •
edited by codebytere
Loading

Closes #421

The unsubscribe button isn't actually updating the subscription. From here it appears the key should be ignored rather than ignore (even though right below mentions ignore).

@Juice805
Copy link
Contributor Author

This should be linked to #421

codebytere
codebytere approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@codebytere codebytere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks! Updated your PR body to close the issue when this merges.

@codebytere codebytere changed the title Fix unsubscribe button fix: unsubscribe button ignoring thread subscription Sep 28, 2021
@codebytere codebytere merged commit 1a11123 into gitify-app:main Sep 28, 2021
@Juice805 Juice805 deleted the patch-1 branch September 28, 2021 16:21
@setchy setchy added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsubscribe does not change subscription status for me
3 participants
@Juice805 @codebytere @setchy