Skip to content

Access to microphone requested. For what? #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
samuelb opened this issue Feb 1, 2024 · 15 comments · Fixed by gitify-app/website#90
Closed
1 task done

Access to microphone requested. For what? #743

samuelb opened this issue Feb 1, 2024 · 15 comments · Fixed by gitify-app/website#90
Labels
documentation Improvements or additions to documentation

Comments

@samuelb
Copy link

samuelb commented Feb 1, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

Hi

Since a few days, macOS prompts me to allow access to the microphone for Gitify. This popup appears every time Gitify shows me an notification about a new or updated PR.

I find this suspicious, since this tool shouldn't require the microphone for anything. Or does it?

I installed Gitify with Homebrew and the version is 4.6.1. My files in the /Applications/Gitify.app folder matches the once from the downloadable zip from Github.

Why does Gitify require microphone access?

🪜 Steps To Reproduce

Not sure if this is a occurrence specific on my system and therefore I don't know really how to reproduce this on any other system. I basically installed and configured Gitify. Then it starts to prompt for microphone access when PR activity in my repos would show a notification in Gitify.

ℹ System Info

MacBook Air M1 macOS 14.3

📸 Screenshots

No response

@samuelb samuelb added the bug Something isn't working label Feb 1, 2024
@bmulholland
Copy link
Collaborator

This is weird. I'm also on macOS 14.3 with Gitify 4.6.1 installed via Homebrew, and I don't experience it. I checked Settings > Privacy > Microphone, and Gitify isn't listed. I don't know all the lines of the codebase, but I'm pretty confident we haven't added something to do with a mic in recent releases. Given you're the only person who's reported this, it's more likely something about your setup.

@mthines
Copy link

mthines commented Feb 2, 2024

I get the same request and do not like it
Macbook M3 Pro, macOS 14.3 (23D56)

@larsgreason
Copy link

larsgreason commented Feb 15, 2024

+1, Apple M1 Pro, Sonoma. Reproducible by quitting and starting again, but stops if clearing all notifications before quit.

Gitify is listed under Settings > Privacy&Security > Microphone.

EDIT: Actually (since I don't want to allow access), the application is currently unusable, I get three consecutive dialogs for mic access every time there's a notification.

@setchy
Copy link
Member

setchy commented Feb 15, 2024

I found this when searching the apps plist

adam@air ~ % grep Microphone -A 1 /Applications/Gitify.app/Contents/Info.plist 

    <key>NSMicrophoneUsageDescription</key>
    <string>This app needs access to the microphone</string>

@afonsojramos - could this be linked to the warning in the v4.6.1 release notes - re the macOS build being built on your machine until we resolve #696

@setchy
Copy link
Member

setchy commented Feb 15, 2024

Searching for all mentions of access returns

adam@air ~ % grep access -B 1 /Applications/Gitify.app/Contents/Info.plist

    <key>NSBluetoothAlwaysUsageDescription</key>
    <string>This app needs access to Bluetooth</string>
    <key>NSBluetoothPeripheralUsageDescription</key>
    <string>This app needs access to Bluetooth</string>
    <key>NSCameraUsageDescription</key>
    <string>This app needs access to the camera</string>
--
    <key>NSMicrophoneUsageDescription</key>
    <string>This app needs access to the microphone</string>

none of which are part of our entitlements file - https://github.com/gitify-app/gitify/blob/main/entitlements/entitlements.mac.plist

@adufr
Copy link
Contributor

adufr commented Feb 15, 2024

NSMicrophoneUsageDescription
This app needs access to the microphone

I tried searching for this too in my local repo, the only place it came up was in node_modules/electron/dist/Electron.app/Contents/Info.plist 🤔

@bmulholland
Copy link
Collaborator

Yeah and the first place I checked on was Electron's setting to ask for mic, but there's nothing in this repo about that. Super weird. Is there something about the build process that introduces it?

@afonsojramos
Copy link
Member

That's very weird... I'll see if the switch to electron forge fixes this by any chance.

@bmulholland
Copy link
Collaborator

I also wonder if the electron upgrades will help.

@samuelb
Copy link
Author

samuelb commented Feb 19, 2024

I discovered that the microphone permission prompt wont show up if "Play sound" in Gitify is turned off or when having a bluetooth headset connected.

@bmulholland
Copy link
Collaborator

Just to make sure I understand: you're saying this prompt only happens if:

  1. "Play Sound" is enabled in Gitify, AND
  2. You have a Bluetooth Headset connected, AND
  3. You receive a new notification

Is that right?

@samuelb
Copy link
Author

samuelb commented Feb 19, 2024

Prompt happens if:

  1. "Play Sound" is enabled in Gitify, AND
  2. You don't have a Bluetooth Headset connected, AND
  3. You receive a new notification

Sorry when my wording was not clear in my previous message.

@bmulholland
Copy link
Collaborator

Wow super weird. Thanks for the clue!

@setchy setchy added documentation Improvements or additions to documentation and removed bug Something isn't working labels Mar 21, 2024
@setchy
Copy link
Member

setchy commented Mar 21, 2024

Labeling this as documentation. We can look to update both the README, and the FAQ for gitify.io

@setchy
Copy link
Member

setchy commented Apr 6, 2024

#970 will remove these from the macOS builds going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants