-
Notifications
You must be signed in to change notification settings - Fork 272
signing of v4.6.0
is broken
#696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oof, yeah, looks like you maybe intended to upgrade from 13 -> 14, but instead it went from 13 -> 22? |
@bmulholland First guess is actually that the old Because I went through all of the breaking changes and nothing jumped out. If the notary tool doesn't fix it, I'll rollback. |
As per https://github.com/gitify-app/gitify/actions/runs/7185499140/job/19568926668 can you add the teamId secret @manosim, so that we can use it? |
I've been running |
@setchy same here, the issue here is with the signing of it :/ |
I'll try to dedicate some extra energy on this. But it is hard to replicate as it only happens in CI. |
@bmulholland @setchy anyone against trying electron-forge over electron-builder? |
No preference on my side |
The @electron/notarize v2.3.0 update had this interesting mention in the changelogs |
Nice catch, really appreciate reviewing changelogs along with merging the updates. That's merged in now, maybe we could try another release and see if the signing is fixed? |
I tried to draft v4.7.1 this morning, but was getting the same notorized issues |
Darn. |
Sorry, I don't know if that helps but I upgraded locally from 4.5.1 to 4.6.1 with brew and I didn't get any error. It works. |
Full disclosure: we're still unsure why the signing isn't working. We pluck away at it when we can. |
🔍 Is there already an issue for your problem?
📝 Description
Likely an side-effect of the upgrade to electron
v22
,v4.6.0
is broken, as such I have deleted the release and tag.🪜 Steps To Reproduce
N/A
ℹ System Info
The text was updated successfully, but these errors were encountered: