Skip to content

refactor: improve PAT login experience #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/fields/FieldInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const FieldInput: FC<IFieldInput> = ({
return (
<Field name={name}>
{({ input, meta: { touched, error } }) => (
<div className="mt-2">
<div className="mb-4">
<label
className="block tracking-wide text-grey-dark text-sm font-semibold mb-2"
htmlFor={input.name}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions src/routes/LoginWithToken.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,17 @@ export const LoginWithToken: FC = () => {
helpText={
<div>
<div>
Create a Personal Access Token on GitHub and paste above.
</div>
<div>
The required scopes will be selected for you.{' '}
<button
type="button"
className={`px-2 py-1 my-2 text-xs ${buttonClasses}`}
className={`px-2 py-1 text-xs ${buttonClasses}`}
onClick={() => openLink(getNewTokenURL())}
>
Generate a PAT
</button>
</button>{' '}
on GitHub and paste above.
</div>
<div className="italic mt-1">
The required scopes will be selected for you.
</div>
</div>
}
Expand All @@ -90,7 +90,7 @@ export const LoginWithToken: FC = () => {
helpText={
<div>
<div>Defaults to github.com.</div>
<div className="italic">
<div className="italic mt-1">
Change only if you are using GitHub Enterprise Server.
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/routes/__snapshots__/LoginEnterprise.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions src/routes/__snapshots__/LoginWithToken.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.