feat(refresh): reset interval on manual refresh

[setchy]

This PR further helps reduce the chance of rate-limiting conditions by

• resetting the automated refresh timer upon a manual refresh (default: 1 minute) to prevent manual+auto fetching being close together
• disabling the manual refresh button, if clicked, until the next internal (default: 1 minute) to prevent repeated clicks removed based on PR feedback

I have also taken the opportunity to refactor the hardcoded fetch interval into our Constants file

[adufr]

Just sharing my opinion about this: first point looks good to me but I don't agree with the second, IMO the user should be free to refresh whenever he wants, and if he gets rate-limited because he clicked the refresh button too many times, too bad for him but that's his problem
I often use this button and this change would badly affect my experience 🙁

[adufr]

However, having a configurable interval could probably also help with the rate-limiting issue?
This way user would have more control over this issue, and if they report problems we could just instruct them to increase their refresh interval

[setchy]

Just sharing my opinion about this: first point looks good to me but I don't agree with the second, IMO the user should be free to refresh whenever he wants, and if he gets rate-limited because he clicked the refresh button too many times, too bad for him but that's his problem I often use this button and this change would badly affect my experience 🙁

You have a need to manually refresh multiple times within the minute? 🤔

[setchy]

@afonsojramos @brandonweiss - what is your take on item 2 above. Should we pull it or keep it?

[setchy]

However, having a configurable interval could probably also help with the rate-limiting issue?

Raised this as a new FR #1027 1027

[afonsojramos]

Agree with @adufr here. Refreshing manually may increase usage, but it was manual, so that's the user's responsibility. We should not take that "power" away imo.

[setchy]

Agree with @adufr here. Refreshing manually may increase usage, but it was manual, so that's the user's responsibility. We should not take that "power" away imo.

OK then....

[afonsojramos]

Reverting the change in e62aa37, we can iterate in the future if needed. Let's get 5.3.0 out!