Skip to content

feat(error): handle network connection errors #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 17, 2024

Screenshot 2024-04-17 at 8 14 38 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Apr 17, 2024
@setchy setchy added this to the Release 5.4.0 milestone Apr 17, 2024
@bmulholland
Copy link
Collaborator

bmulholland commented Apr 17, 2024

Nice! I'd probably have just added a linebreak in that two-line error and translated that to a <br> or something. But maybe I'm just lazy.

@setchy
Copy link
Member Author

setchy commented Apr 17, 2024

Nice! I'd probably have just added a linebreak in that two-line error and translated that to a or something. But maybe I'm just lazy.

Fair feedback, and I did pivot 3 times to land on this 🤷

I did briefly go down that route, but it would require something like this - manipulating innerHTML feels smelly, and those two libraries haven't been released in ages

I also looked into having description support ReactNode | string like we do for the component/fields, but building this in the Constants file got wild with nested React.createElements

Using an array felt like the lesser of the other "evils" :p But happy to pivot as the team sees best

@bmulholland
Copy link
Collaborator

Reasoning sounds good to me :)

@setchy
Copy link
Member Author

setchy commented Apr 17, 2024

@afonsojramos - thoughts? 👍 👎

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning seems sound and I suppose the impact isn't that bad. Let's go with it!

@setchy setchy merged commit 23c1bae into main Apr 17, 2024
9 checks passed
@setchy setchy deleted the feature/network-connection-error-handling branch April 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants