refactor: icons util with color enum

src/components/NotificationRow.tsx

@@ -16,11 +16,11 @@ import {
 import { AppContext } from '../context/App';
 import type { Notification } from '../typesGithub';
 import { openExternalLink } from '../utils/comms';
+import { formatForDisplay, openInBrowser } from '../utils/helpers';
 import {
   getNotificationTypeIcon,
   getNotificationTypeIconColor,
-} from '../utils/github-api';
-import { formatForDisplay, openInBrowser } from '../utils/helpers';
+} from '../utils/icons';
 import { formatReason } from '../utils/reason';
 
 interface IProps {

src/types.ts

@@ -93,3 +93,10 @@ export interface FormattedReason {
   title: string;
   description: string;
 }
+
+export enum IconColor {
+  GREEN = 'text-green-500',
+  RED = 'text-red-500',
+  PURPLE = 'text-purple-500',
+  GRAY = 'text-gray-500 dark:text-gray-300',
+}

src/utils/github-api.test.ts → src/utils/icons.test.ts

@@ -1,10 +1,7 @@
 import type { StateType, Subject, SubjectType } from '../typesGithub';
-import {
-  getNotificationTypeIcon,
-  getNotificationTypeIconColor,
-} from './github-api';
+import { getNotificationTypeIcon, getNotificationTypeIconColor } from './icons';
 
-describe('utils/github-api.ts', () => {
+describe('utils/icons.ts', () => {
   describe('getNotificationTypeIcon - should get the notification type icon', () => {
     expect(
       getNotificationTypeIcon(

src/utils/github-api.ts → src/utils/icons.ts

@@ -24,6 +24,7 @@ import {
   XIcon,
 } from '@primer/octicons-react';
 import type { FC } from 'react';
+import { IconColor } from '../types';
 import type { Subject } from '../typesGithub';
 
 export function getNotificationTypeIcon(subject: Subject): FC<OcticonProps> {
@@ -92,21 +93,21 @@ export function getNotificationTypeIcon(subject: Subject): FC<OcticonProps> {
   }
 }
 
-export function getNotificationTypeIconColor(subject: Subject): string {
+export function getNotificationTypeIconColor(subject: Subject): IconColor {
   switch (subject.state) {
     case 'open':
     case 'reopened':
     case 'ANSWERED':
     case 'success':
-      return 'text-green-500';
+      return IconColor.GREEN;
     case 'closed':
     case 'failure':
-      return 'text-red-500';
+      return IconColor.RED;
     case 'completed':
     case 'RESOLVED':
     case 'merged':
-      return 'text-purple-500';
+      return IconColor.PURPLE;
     default:
-      return 'text-gray-500 dark:text-gray-300';
+      return IconColor.GRAY;
   }
 }