Skip to content

refactor: replace axios.all and axios.spread #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

refactor: replace axios.all and axios.spread #1063

merged 2 commits into from
Apr 29, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 27, 2024 •
edited
Loading

axios.all and axios.spread are both deprecated (source)

Replace with Promise.all as per their concurrency example

@setchy setchy added the refactor Refactoring of existing feature label Apr 27, 2024
@setchy setchy added this to the Release 5.5.0 milestone Apr 27, 2024
bmulholland
bmulholland approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, almost the exact same code but a more standard approach :)

@setchy setchy merged commit f13124d into main Apr 29, 2024
6 of 7 checks passed
@setchy setchy deleted the refactor/axios-all branch April 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @bmulholland