feat: add pr review icons (approved, requested changes, commented, dismissed)

[setchy]

Closes #682

For Pull Request notifications, when `detailed notifications setting is enabled, fetch PR reviews and find the most recent for the authenticated user

Will show an additional icon on the notification row, as pictured below.

Feedback Areas
I'd appreciate feedback on the following:

• are there better positions for the icon?
• mouse-over text (closely modeled off the GitHub UI wording)

Broader discussion
This has also got me thinking more generally if we could/should show PR Approval icons for all reviewers. If so, what would we show when there is multiple people with feedback?

[setchy]

@bhingston-va - as the feature requestor - would really value your input on this 🙏

[afonsojramos]

How does it look on hover? When there's more icons?

[bhingston-va]

Looks great to me! This is awesome. I'll be honest this was more of need when the notifications would duplicate/inconsistent state. This inconsistent state was fixed in v5.4.0 I believe. That said this would be really cool. Thanks for actioning on it so fast. 🎉

[bhingston-va]

How does it look on hover? When there's more icons?

Looking again. On hover, I see the other icons likely collide or get squished. Also be confusing with the new "approved" icon and the existing "Mark as done" icon on hover (as they are the same icon). I wonder if putting this new icon with the "latest update". With the idea it is just our review and could be later iterated on to support multiple reviewers by having the picture of the reviewer with the icon of the review state.

before	after

[setchy]

Happy to try adding the icons to the footer as you've mocked up and see how that goes.

Perhaps to generalize the solution, we could

• Parse the reviews array
• Find the most recent review state for each reviewer
• Show up to 3 icons per notification footer (approved, changes requested, commented/dismissed)
• Dynamically generate the mouse-over text to summarize which users have left which reviews

[bhingston-va]

Show up to 3 icons per notification footer (approved, changes requested, commented/dismissed)

Minor detail, consider always including "my review" if it exists. Up to 3 icons I like but either 3 icons of others or my review and 2 others when there are 3 or more reviews. Ah, I understand your suggestion for multi reviews. Show all or at least up to 3 review states (I see you are adding dismissed so maybe 4 states/icons) and on hover you show who all did that review state. I like it a lot.

I do like the original at a glance to see my review. That said showing all review states and I just need to hover to see who did them is a general solution with more value (at the cost of a hover to see my review if any).

[setchy]

Following the above discussion, I've pushed updates that now

• add the icons to the notification row footer
• fetch the latest review for each reviewer
• generate appropriate descriptions

[setchy]

Here is an example of multiple review states using stubbed data

For now I made the decision to show Commented as YELLOW and Dismissed as GRAY so that they've visually different (in the GitHub UI they're combined into a single GRAY icon)

[afonsojramos]

Nice job, looking good!

[setchy]

@bhingston-va - just wanted to check that this impl covers the enhancement you were hoping for?