-
Notifications
You must be signed in to change notification settings - Fork 272
feat(accounts): enhance auth account data structure #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@afonsojramos @bmulholland - I'd appreciate if you could please test this branch locally when you have a moment. |
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
…-app/gitify into refactor/new-account-type
OK - @bmulholland @afonsojramos - I feel like this is ready for your eyes and feedback. It largely focuses on the new account data structure and legacy account migration logic. If all goes well, you'll notice no difference :) |
👀 looking into the coverage drop |
@setchy I think you might have tagged the wrong person 😬 |
Any chance there's more that could be pulled out? Not sure when I'll have time for an 800 line review :) |
It's as lean as i think makes sense... It's not as scary as it may appear |
@bmulholland - thinking more about this... I could do the following PRs
lmk what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managed to find the time and it looks good to me code wise! Will test locally in the next few minutes!
Thanks @afonsojramos - anything explode haha |
@setchy When I opened I didn't have the live one open. And now if I try to open the live one it doesn't open either. |
🥹 |
Looking good! |
Introduce new accounts type that unlocks the possibility of authenticating one or more accounts at once, across any combination of support auth methods (personal access token or oauth app) and across any platforms (github cloud or github enterprise server)
Update logic to support new account structures
Implemented a legacy auth/account migration process to help seamlessly transition existing authenticated users.
Note: there is a handful of follow-up PRs required in order to expand functionality beyond "at most one account of each auth method"