-
Notifications
You must be signed in to change notification settings - Fork 272
feat: labels indicator #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: labels indicator #1161
Conversation
setchy
commented
May 31, 2024
Tests still WIP. Would appreciate feedback on color and icon. Went with a purple tag for the time being |
My take is that using color where it's not conveying information makes it harder to parse the places where color is important (like PR status). Matching the text color should be fine, right? |
appreciate the feedback. thanks @bmulholland. I'll make that change. I might also try and see what render the labels as |
updated to use pill format as to-be introduced by #1169 ![]() |
…app/gitify into feature/labels-indicator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the mocks and increased null handling just incase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking clean now, thanks 🧽