Skip to content

feat: add notification count at account and repository level #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: add notification count at account and repository level #1278

wants to merge 3 commits into from

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 19, 2024 •
edited
Loading

could help with #979 - seeking feedback 🙏

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 19, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 19, 2024
afonsojramos
afonsojramos requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for trying to block yet another UI change, but I think that, once again, this will add complexity to something that doesn't need the complexity. Tbh, as the person that opened the issue in question, I don't think it makes sense anymore. :(

@setchy
Copy link
Member Author

setchy commented Jun 20, 2024

I'm sorry for trying to block yet another UI change, but I think that, once again, this will add complexity to something that doesn't need the complexity. Tbh, as the person that opened the issue in question, I don't think it makes sense anymore. :(

All good. Let's close the issue then.

My goal largely is to get that down to a smaller list. Less is more.

@setchy setchy closed this Jun 20, 2024
@setchy setchy deleted the feature/notification-count-pill branch July 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos requested changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos