-
Notifications
You must be signed in to change notification settings - Fork 272
feat: settings button toggle between settings and notifications #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
afonsojramos
merged 8 commits into
gitify-app:main
from
hughlilly:settings-button-toggle
Sep 14, 2023
Merged
feat: settings button toggle between settings and notifications #553
afonsojramos
merged 8 commits into
gitify-app:main
from
hughlilly:settings-button-toggle
Sep 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings now toggles btw notifications & settings; Refresh shows notifs.
This reverts commit 3d88d66.
afonsojramos
approved these changes
Sep 14, 2023
Nice QoL PR 👌 |
afonsojramos
approved these changes
Sep 14, 2023
Thanks; what does “QoL” mean? |
Quality of Life 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552. Not sure if this is the best way to go about what I’m trying to do, so I’d appreciate it if someone with much more experience than me would check over my suggestions. Thanks!
p.s. I think I stuffed up the commits. I wanted to make some other changes in 3d88d66 on another branch but they got included here. I hope I’ve reverted them properly.