Skip to content

chore(routing): Switch to new react-router syntax #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

bmulholland
Copy link
Collaborator

@bmulholland
Copy link
Collaborator Author

bmulholland commented Oct 2, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bmulholland
Copy link
Collaborator Author

Note that I deviated from https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f#get-started-upgrading-today in the PrivateRoute refactor, because https://reactrouter.com/en/main/upgrading/v5#upgrade-to-react-router-v51 says to remove , which that suggested. I think that will work okay but I don't have a good way to test this -- how can you manually go to a route in Electron? If you have a way to test the redirect works okay, and the from passes through properly, that would be good to double-check. Low-risk, though, this should be rarely (if ever) hit.

@bmulholland bmulholland force-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 8bb372b to 23967bd Compare October 2, 2023 10:22
@bmulholland bmulholland force-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 23967bd to 9732ce4 Compare October 2, 2023 10:28
@bmulholland bmulholland force-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 9732ce4 to b456361 Compare October 2, 2023 10:28
@bmulholland bmulholland changed the title chore: Switch to new react-router syntax chore(routing): Switch to new react-router syntax Oct 2, 2023
@afonsojramos
Copy link
Member

All you need to do is just to drop in a Link component to a certain route and you can see it in action. Tested locally and it seemed to work!

@afonsojramos afonsojramos merged commit d5d0243 into main Oct 2, 2023
@afonsojramos afonsojramos deleted the 10-02-chore_Switch_to_new_react-router_syntax branch October 2, 2023 23:22
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants