Skip to content

docs: add myself to codeowners #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jan 22, 2024

No description provided.

@setchy setchy requested a review from bmulholland as a code owner January 22, 2024 15:21
@afonsojramos
Copy link
Member

@setchy do you know why it is always @bmulholland being requested in PRs?

@setchy
Copy link
Member Author

setchy commented Jan 22, 2024

@setchy do you know why it is always @bmulholland being requested in PRs?

I did look into why your name isn't showing... I thought I may have made a typo, but after triple checking it's certainly the same username... 🤔 🤷

@setchy
Copy link
Member Author

setchy commented Jan 22, 2024

@afonsojramos - is it fair to assume you have write permissions

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Who can use this feature

People with write permissions for the repository can create or edit the CODEOWNERS file and be listed as code owners. People with admin or owner permissions can require that pull requests have to be approved by code owners before they can be merged

@setchy
Copy link
Member Author

setchy commented Jan 22, 2024

@bmulholland
Copy link
Collaborator

I think the latest line overwrites the previous one. The correct syntax is all usernames on one line

@setchy setchy merged commit 9682b42 into gitify-app:main Jan 22, 2024
@setchy
Copy link
Member Author

setchy commented Jan 22, 2024

Good catch @bmulholland 🙇

@setchy setchy deleted the docs/codeowners-update branch February 19, 2024 12:49
@setchy setchy added the documentation Improvements or additions to documentation label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants