refactor: simplify notification html url logic

src/__mocks__/mock-state.ts

@@ -1,14 +1,9 @@
 import { Appearance, AuthState, SettingsState } from '../types';
-import { mockedUser } from './mockedData';
+import { mockedUser, mockedEnterpriseAccounts } from './mockedData';
 
 export const mockAccounts: AuthState = {
   token: 'token-123-456',
-  enterpriseAccounts: [
-    {
-      token: 'token-gitify-123-456',
-      hostname: 'github.gitify.io',
-    },
-  ],
+  enterpriseAccounts: mockedEnterpriseAccounts,
   user: mockedUser,
 };
 

src/__mocks__/mockedData.ts

@@ -383,6 +383,108 @@ export const mockedGraphQLResponse: GraphQLSearch = {
               },
             },
           },
+          {
+            node: {
+              viewerSubscription: 'IGNORED',
+              title: '1.16.0',
+              url: 'https://github.com/manosim/notifications-test/discussions/612',
+              comments: {
+                edges: [
+                  {
+                    node: {
+                      databaseId: 2215656,
+                      createdAt: '2022-02-20T18:33:39Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2217789,
+                      createdAt: '2022-02-21T03:30:42Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2223243,
+                      createdAt: '2022-02-21T18:26:27Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2232922,
+                              createdAt: '2022-02-23T00:57:58Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2232921,
+                      createdAt: '2022-02-23T00:57:49Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2258799,
+                      createdAt: '2022-02-27T01:22:20Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300902,
+                              createdAt: '2022-03-05T17:43:52Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2297637,
+                      createdAt: '2022-03-04T20:39:44Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300893,
+                              createdAt: '2022-03-05T17:41:04Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2299763,
+                      createdAt: '2022-03-05T11:05:42Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300895,
+                              createdAt: '2022-03-05T17:41:44Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                ],
+              },
+            },
+          },
         ],
       },
     },

src/components/NotificationRow.test.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import * as TestRenderer from 'react-test-renderer';
 import { fireEvent, render } from '@testing-library/react';
 
-const { shell } = require('electron');
+import * as helpers from '../utils/helpers';
 
 import { AppContext } from '../context/App';
 import { mockedSingleNotification } from '../__mocks__/mockedData';
@@ -11,7 +11,7 @@ import { mockAccounts, mockSettings } from '../__mocks__/mock-state';
 
 describe('components/Notification.js', () => {
   beforeEach(() => {
-    jest.spyOn(shell, 'openExternal');
+    jest.spyOn(helpers, 'openInBrowser');
   });
 
   afterEach(() => {
@@ -51,7 +51,7 @@ describe('components/Notification.js', () => {
     );
 
     fireEvent.click(getByRole('main'));
-    expect(shell.openExternal).toHaveBeenCalledTimes(1);
+    expect(helpers.openInBrowser).toHaveBeenCalledTimes(1);
     expect(removeNotificationFromState).toHaveBeenCalledTimes(1);
   });
 
@@ -76,7 +76,7 @@ describe('components/Notification.js', () => {
     );
 
     fireEvent.click(getByRole('main'));
-    expect(shell.openExternal).toHaveBeenCalledTimes(1);
+    expect(helpers.openInBrowser).toHaveBeenCalledTimes(1);
     expect(markNotificationDone).toHaveBeenCalledTimes(1);
   });
 

src/typesGithub.ts

@@ -126,7 +126,7 @@ export interface Owner {
 export interface Subject {
   title: string;
   url?: string;
-  state: StateType;
+  state?: StateType;
   latest_comment_url?: string;
   type: SubjectType;
 }