Skip to content

feat: add support for approval_requested reason #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 23, 2024

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Feb 23, 2024
@setchy setchy changed the title feat: add approval_requested reason feat: add support for approval_requested reason Feb 23, 2024
@afonsojramos
Copy link
Member

afonsojramos commented Feb 24, 2024

If we are adding all of these new notifications, should we have a more granular control of what notifications gitify fetches to the user?
Just pointing out that we should probably roll that feature out before we roll out a new version.

@setchy
Copy link
Member Author

setchy commented Feb 24, 2024

If we are adding all of these new notifications, should we have a more granular control of what notifications gitify fetches to the user?
Just pointing out that we should probably roll that feature out before we roll out a new version.

Perhaps... there is a feature request ticket already for filtering by reason (#264)...

Note, we aren't adding ANY new notifications actually, what I've been doing is ensuring that we have fewer Unknown notifications that cannot be clicked on.

@afonsojramos afonsojramos merged commit b824f33 into gitify-app:main Feb 24, 2024
@setchy setchy deleted the feature/support-approval-requested-reason branch February 24, 2024 11:18
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
* feat: add approval_requested reason

* feat: add approval_requested reason
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants