Skip to content

feat: show notification last update user #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 18, 2024

Closes #439

Shows the last update user when available.

Screenshot 2024-03-18 at 2 12 27 PM

Currently this logic is part of the subject enrichment process, which is controlled by SettingsState.colors. Perhaps this setting should be renamed to something more suitable now that it handles fetching notification state/color and notification last updated user details

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 18, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squeezing that sweet gh api 🤓

@afonsojramos afonsojramos merged commit 2f3e11f into gitify-app:main Mar 19, 2024
9 checks passed
@setchy setchy deleted the feature/notification-user branch March 19, 2024 02:01
@setchy
Copy link
Member Author

setchy commented Mar 19, 2024

SQUEEZE!!!

adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Display who did the thing that caused the notification
2 participants