feat: notification user avatar

[setchy]

Took this idea from the GitHub Android application...

Display last updated user avatar. Users name is available when mousing over.

[adufr]

This is a really cool addition!

I see that the PR is still in draft? Is there something missing to make it ready for review?

[setchy]

Still in draft. I need to overhaul the User-related types first.

[setchy]

Took a bit of git wrestling to get this branch back up-to-date...

appreciate feedback on the layout of the profile icon. i played around with it being on the far left, but wasn't sure where the Subscribed, Mentioned notification reasons would be best displayed then...

[setchy]

How do we feel about the structure of that footer.

It will follow two patterns, depending on whether the notification event contains user data.

1. <reason> - <avatar img> updated about <some time>
2. <reason> - Updated about <some time>

Some open questions that are going through my mind

• should the avatar image be at the start of the notification. if so, where do we put the reason?
• should we have a default avatar image for unknown user. that would ensure each row has a consistent shape. currently it can vary depending on the notification content (example below)

[adufr]

I like that there's no avatar when the reason isn't a user (like for the worflow run notification in your last screenshot); it helps me quickly identify different kind of notifications

I don't really have an opinion on the placement of the avatar, it doesn't look too bad like this...
Or maybe having it at the end (like, "updated about 4 hours ago by <avatar>)..? I don't know, it looks ok to me like this!

[bmulholland]

I kinda like the avatar at the start, makes it more like an english sentence, "actor acted at time"

[setchy]

I kinda like the avatar at the start, makes it more like an english sentence, "actor acted at time"

I'll mock up an example of what this may look like.

[setchy]

Examples of what an alternate layout could look like.

Format is <avatar> <reason type> <update at>, where

• avatar is user avatar when known, else fallback to feed person octicon
• reason type used instead of previous hardcoded updated. Each reason.type will be updated to be correct tense (ie: Mention -> Mentioned, etc)
• updated at, no change

My 2 cents - this feels much more natural

[bmulholland]

I love those, clean and clear :)

[adufr]

Looks great!

would like a fresh approval after the ux-pivot

[afonsojramos]

Looks awesome!! Let me run this locally to check it out better!

[setchy]

Looks awesome!! Let me run this locally to check it out better!

Thanks mate. Appreciate any feedback, particularly on the changes to the new reason mappings.

[afonsojramos]

We lose the usernames, but we get the avatars, I think this is a positive change overall, love it!

Clean implementation as well, all wins!

[setchy]

We lose the usernames, but we get the avatars, I think this is a positive change overall, love it!

Clean implementation as well, all wins!

thanks @afonsojramos, appreciate the feedback. usernames still available on avatar hover :)

[afonsojramos]

We lose the usernames, but we get the avatars, I think this is a positive change overall, love it!

Clean implementation as well, all wins!

thanks @afonsojramos, appreciate the feedback. usernames still available on avatar hover :)

I know, but we still lose them at a glance, which is mostly what matters.