Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Provide the browser notification #261

Closed
Tracked by #29
noahingh opened this issue Dec 15, 2021 · 0 comments · Fixed by #268
Closed
Tracked by #29

Provide the browser notification #261

noahingh opened this issue Dec 15, 2021 · 0 comments · Fixed by #268
Labels
enhancement New feature or request
Milestone

Comments

@noahingh
Copy link
Member

noahingh commented Dec 15, 2021

At this moment, we're providing the Slack notification for deployments and reviews, but it is possible to provide the browser notification.

The notification logic is determined by the kind (deployment or review). The browser should notify only the user who triggers the deployment for the' deployment' event. For the review event, it should notify the requester when the review is responded to, but it should notify the reviewer when the review is requested.

Implement

We should implement two parts for the browser notification like the below:

  1. Provide the setting to configure the notification whether to receive or not.
  2. Notify the user when the event is fired.
@noahingh noahingh reopened this Dec 15, 2021
@noahingh noahingh added this to the v0.5 milestone Dec 15, 2021
@noahingh noahingh added the component: ui This issue or pull request is related to the feature of the UI-side label Dec 15, 2021
@noahingh noahingh linked a pull request Dec 18, 2021 that will close this issue
2 tasks
@noahingh noahingh mentioned this issue Dec 18, 2021
40 tasks
@noahingh noahingh added enhancement New feature or request and removed component: ui This issue or pull request is related to the feature of the UI-side labels Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant